Skip to content

fix for new version of golden files #6771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 17, 2025
Merged

fix for new version of golden files #6771

merged 3 commits into from
Mar 17, 2025

Conversation

davidmotson
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

Test Results

 18 files  +  4   18 suites  +4   13s ⏱️ -1s
 85 tests + 62   85 ✅ + 62  0 💤 ±0  0 ❌ ±0 
170 runs  +124  170 ✅ +124  0 💤 ±0  0 ❌ ±0 

Results for commit ea321d2. ± Comparison against base commit 0554f0d.

This pull request removes 23 and adds 85 tests. Note that renamed tests count towards both. 
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

com.google.firebase.vertexai.GenerativeModelTesting ‑ exception thrown when using invalid location
com.google.firebase.vertexai.GenerativeModelTesting ‑ system calling in request
com.google.firebase.vertexai.SchemaTests ‑ basic schema declaration
com.google.firebase.vertexai.SchemaTests ‑ full schema declaration
com.google.firebase.vertexai.SerializationTests ‑ test Candidate serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test GenerateContentResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test Schema serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test countTokensResponse serialization as Json
com.google.firebase.vertexai.SerializationTests ‑ test modalityTokenCount serialization as Json
com.google.firebase.vertexai.VertexAIStreamingSnapshotTests ‑ citation parsed correctly
…

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2025 •
edited
Loading

Coverage Report 1

Affected Products

No changes between base commit (0554f0d) and merge commit (659acff).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/b4UfiKhybz.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 13, 2025 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (0554f0d) and merge commit (659acff).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TBqjJmXdvv.html

@davidmotson davidmotson requested a review from rlazo March 17, 2025 20:19
@davidmotson davidmotson enabled auto-merge (squash) March 17, 2025 21:12
@davidmotson davidmotson merged commit 9b42d84 into main Mar 17, 2025
29 of 30 checks passed
@davidmotson davidmotson deleted the davidmotson.golden_files_fix branch March 17, 2025 23:07
tejasd pushed a commit that referenced this pull request Apr 1, 2025
@davidmotson @tejasd
fix for new version of golden files (#6771)
be7561f 
Co-authored-by: David Motsonashvili <[email protected]>
@firebase firebase locked and limited conversation to collaborators Apr 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidmotson @google-oss-bot @rlazo